Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19452] Fix 3.0.x rebase workflow #4323

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[19452] Fix 3.0.x rebase workflow #4323

merged 1 commit into from
Jan 30, 2024

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented Jan 30, 2024 •
edited by EduPonz
Loading

Description

This PR fixes the 3.0.x rebase workflow adding the missing config required to push the changes after rebasing.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • [N/A] The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Changes are ABI compatible.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: Check CI results: changes do not issue any warning.
  • N/A: Check CI results: failing tests are unrelated with the changes.

@JLBuenoLopez JLBuenoLopez added the skip-ci Automatically pass CI label Jan 30, 2024
@JLBuenoLopez JLBuenoLopez force-pushed the hotfix/3.0.x-rebase-workflow branch 2 times, most recently from 802dc47 to 24b92a3 Compare January 30, 2024 08:05
@JLBuenoLopez
Refs #19452: fix 3.0.x rebase workflow
32e8fdc 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@EduPonz EduPonz added this to the v3.0.0 milestone Jan 30, 2024
@EduPonz EduPonz merged commit 250092c into master Jan 30, 2024
9 checks passed
@EduPonz EduPonz deleted the hotfix/3.0.x-rebase-workflow branch January 30, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JLBuenoLopez @EduPonz